~reviewer/hello-hut#1: --shout loses the accents in my name

--shout loses the accents in my name

Running --shout with an accented name drops the accents:

$ hello-hut Zoë --shout
HELLO, ZOE!

I expected HELLO, ZOË!. This is with 0.1.0.dev0 on Python 3.12.

Status: RESOLVED FIXED
Submitter: Ola Nordin (unverified)
Assignee: No-one
Submitted: 7 months ago
Updated: 7 months ago
Labels: bug

Tomás Varga (unverified) 7 months ago · edit

Thanks for the report! My first version of --shout went through str.encode("ascii", "ignore"), which is where the accents went. I'll switch to plain str.upper() and add a test with Zoë.

Dana Whitfield added bug 7 months ago

Dana Whitfield (unverified) REPORTED FIXED 7 months ago · edit

Fixed on main; the new test is test_shout_keeps_accents. Thanks both!