~reviewer/hello-hut

Add an option to repeat the greeting

Sometimes I want hello-hut to greet a whole room. Could we have something like:

hello-hut --count 3 everyone

It should probably refuse 0 and negative numbers.

Status
RESOLVED IMPLEMENTED
Submitter
Felix Brandt (unverified)
Assignee
No-one
Submitted
6 months ago
Updated
4 months ago
Labels
feature good-first-issue

Dana Whitfield (unverified) 6 months ago · edit

Sounds reasonable, and small enough for a first contribution. Please print a clear error for values below 1 and exit with status 2.

Dana Whitfield added feature 6 months ago

Dana Whitfield added good-first-issue 6 months ago

Dana Whitfield REPORTED CONFIRMED 6 months ago

Felix Brandt (unverified) 4 months ago · edit

I sent a patch to the list. It adds --count N and a test for the error case.

Dana Whitfield (unverified) CONFIRMED IMPLEMENTED 4 months ago · edit

Applied, thanks Felix! This will be in 0.2.0.

Register here or Log in to comment, or comment via email.